Post new topic   Reply to topic
View previous topic Printable version Log in to check your private messages View next topic
Author Message
marcOffline
Post subject: Arrandale edp fix [black screen after suspend]  PostPosted: 07.01.2011, 00:23



Joined: 2010-09-12
Posts: 1

Status: Offline
Hi there,

it's nice to see a non "black screen" with kernel relase 2.6.37.
Since v36 I was forced to compile and patch the drm-intel-next tree by myself.
It could be so easy, but after resume from suspend (S3) the "black screen" shows up again (v37).
The fix only contains one line (and works - at least for me)!

      Code:

*** a/drivers/gpu/drm/i915/intel_dp.c   2011-01-07 01:14:43.487255988 +0100
--- b/drivers/gpu/drm/i915/intel_dp.c   2011-01-07 01:16:10.934256009 +0100
*************** static void intel_dp_prepare(struct drm_
*** 945,950 ****
--- 945,951 ----
 
        if (is_edp(intel_dp)) {
                ironlake_edp_backlight_off(dev);
+               ironlake_edp_panel_off(dev);
                ironlake_edp_panel_on(intel_dp);
                if (!is_pch_edp(intel_dp))
                        ironlake_edp_pll_on(encoder);


It would be great to see it in the next release Smile

Regards

Marc

PS: There is also a bugreport on freedesktop.org https://bugs.freedesktop.org/show_bug.cgi?id=30738.
 
 View user's profile Send private message  
Reply with quote Back to top
slhOffline
Post subject: RE: Arrandale edp fix [black screen after suspend]  PostPosted: 07.01.2011, 00:46



Joined: 2010-08-25
Posts: 724

Status: Offline
hmm, I don't see a corresponding patch in linux-next yet and this one has a potential to break other systems, particularly as display port is becoming more and more common these days; in other words this might trade one bug breaking your particular notebook for another that might break others...

Personally I'd prefer this, or something like this, getting blessed by upstream (yes, I know who Jesse Barnes is - but it almost appears as if he'd be reluctant to push it, especially as he posted that patch two months ago already) first, even if the resulting patch would be slightly larger.
 
 View user's profile Send private message  
Reply with quote Back to top
Display posts from previous:     
Jump to:  
All times are GMT - 12 Hours
Post new topic   Reply to topic
View previous topic Printable version Log in to check your private messages View next topic
Powered by Zafenio